Re: [PATCH 1/2] target/arm: Don't allow guest to use unimplemented granule sizes

[Richard Henderson]

On 9/30/22 10:48, Peter Maydell wrote:
@@ -10289,20 +10289,113 @@ static int aa64_va_parameter_tcma(uint64_t tcr, 
ARMMMUIdx mmu_idx)
      }
  }
  
+typedef enum GranuleSize {
+    /* Same order as TG0 encoding */
+    Gran4K,
+    Gran64K,
+    Gran16K,
+    GranInvalid,
+} GranuleSize;

It might be worth using this in ARMVAParameters. Even if you don't do that now, it would 
be worth putting this typedef in internals.h.

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~