Re: [PATCH] coroutine: Make qemu_coroutine_self() return NULL if not in coroutine

[Stefan Hajnoczi]

On Wed, Oct 05, 2022 at 06:34:09PM +0200, Kevin Wolf wrote:
> Am 05.10.2022 um 16:20 hat Alberto Faria geschrieben:
> > qemu_coroutine_self() is used in several places outside of coroutine
> > context (mostly in qcow2 tracing calls).
> > 
> > Ensure qemu_coroutine_self() works properly when not called from
> > coroutine context, returning NULL in that case, and remove its
> > coroutine_fn annotation.
> > 
> > Signed-off-by: Alberto Faria <afa...@redhat.com>
> 
> The coroutine_fn annotation for qemu_coroutine_self() is wrong, but I
> think it already works outside of coroutine context, and consistently in
> all three backends, by returning &leader.

Yes, I remember implementing it specifically so that NULL is never
returned.

The coroutine_fn annotation should be removed.

Stefan

signature.asc
Description: PGP signature