On Mon, Oct 10, 2022 at 2:50 PM Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Mon, Oct 10, 2022 at 01:43:21PM +0530, Ani Sinha wrote: > > On Mon, Oct 10, 2022 at 1:24 PM Ani Sinha <a...@anisinha.ca> wrote: > > > > > > Please see the README file added in patch 10 for more details. > > > Sample runs are as follows: > > > > > > $ ./tests/venv/bin/avocado run -t acpi tests/avocado --tap - > > > ERROR: Missing parentheses in call to 'print'. Did you mean print(...)? > > > (smbios.py, line 92) > > > ERROR: Missing parentheses in call to 'print'. Did you mean print(...)? > > > (smilatency.py, line 47) > > > ERROR: Missing parentheses in call to 'print'. Did you mean print(...)? > > > (testacpi.py, line 158) > > > > None of the above files are avocado tests or avocado related python > > scripts. They are run from within bits in a python 2.7 environment. I > > could not find a mechanism to exclude a directory from avocado tests. > > I also do not think making those scripts python 3 compliant is a good > > use of my time since upgrading bits to use python 3 would be a major > > task unrelated to QEMU testing. > > In one of the later patches copy_test_scripts() copies the files > into the guest image IIUC. > > If you rename them in git, to be .py2 then presumably avocado > wont try to load them, and then in copy_test_scripts you can > give them the normal .py extension for the guest. The .py2 > extension will also make it more obvious to maintainers that > these are different from the rest of the python coded we have.
I did a quick test and this approach seems to work. ./tests/venv/bin/avocado run -t acpi tests/avocado --tap - 1..1 ok 1 tests/avocado/acpi-bits.py:AcpiBitsTest.test_acpi_smbios_bits
