On Thu, Jan 19, 2023 at 01:05:14PM +0100, Philippe Mathieu-Daudé wrote: > This test is failing in gtk-vnc on Darwin: > > $ make check-qtest-aarch64 > ... > 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test > ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672 > > While QEMU picks the sigaltstack coroutine backend, gtk-vnc uses > the ucontext coroutine backend, which might be broken on Darwin.
s/might be/is completely and utterly/ The struct ucontext_t definition on macOS aarch64 is too small, and so getcontext() smashes past the end of the struct overwriting whatever follows the ucontext_t struct. > > Disable this test (current problem being investigated in this thread: > https://lore.kernel.org/qemu-devel/y8kw6x6keb5l5...@redhat.com/). > > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> > --- > tests/qtest/vnc-display-test.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> But keep an eye on this bug: https://github.com/Homebrew/homebrew-core/issues/115413 if it gets fixed before you send a PULL request, we can drop this patch, or failing that, revert it later. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
