Re: [PATCH 02/12] tests/qtest: Do not run lsi53c895a test if device is not present

[Thomas Huth]

On 06/02/2023 16.04, Fabiano Rosas wrote:
The tests are built once for all the targets, so as long as one QEMU
binary is built with CONFIG_LSI_SCSI_PCI=y, this test will
run. However some binaries might not include the device. So check this
again in runtime.
Signed-off-by: Fabiano Rosas <faro...@suse.de>
---
  tests/qtest/fuzz-lsi53c895a-test.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/tests/qtest/fuzz-lsi53c895a-test.c 
b/tests/qtest/fuzz-lsi53c895a-test.c
index 392a7ae7ed..a9254b455d 100644
--- a/tests/qtest/fuzz-lsi53c895a-test.c
+++ b/tests/qtest/fuzz-lsi53c895a-test.c
@@ -112,6 +112,10 @@ static void test_lsi_do_dma_empty_queue(void)
  
  int main(int argc, char **argv)
  {
+    if (!qtest_has_device("lsi53c895a")) {
+        return 0;
+    }

I'm a little bit confused right now ... We're already checking 
CONFIG_LSI_SCSI_PCI in meson.build, and we're only adding the test to 
qtests_i386 there ... so how did you end up in a situation where you needed 
this change?

 Thomas