Thomas Huth <th...@redhat.com> writes:
> On 06/02/2023 16.04, Fabiano Rosas wrote:
>> This test depends on the presence of the pcie-root-port device. Add a
>> build time dependency and a runtime check.
>>
>> Signed-off-by: Fabiano Rosas <faro...@suse.de>
>> ---
>> tests/qtest/meson.build | 3 ++-
>> tests/qtest/virtio-net-failover.c | 5 +++++
>> 2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
>> index e97616d327..431b623df9 100644
>> --- a/tests/qtest/meson.build
>> +++ b/tests/qtest/meson.build
>> @@ -73,7 +73,8 @@ qtests_i386 = \
>> (config_all_devices.has_key('CONFIG_ESP_PCI') ? ['am53c974-test'] : [])
>> + \
>> (config_host.has_key('CONFIG_POSIX') and
>> \
>> config_all_devices.has_key('CONFIG_ACPI_ERST') ? ['erst-test'] : []) +
>> \
>> - (config_all_devices.has_key('CONFIG_VIRTIO_NET') and
>> \
>> + (config_all_devices.has_key('CONFIG_PCIE_ROOT') and
>> \
>
> CONFIG_PCIE_ROOT looks wrong ... hw/pci-bridge/meson.build uses
> CONFIG_PCIE_PORT instead, so I assume this is a typo?
>
> Also, do we really need a run-time check if we already have a build-time
> check?
I guess not. It seems it was the typo that made it necessary. I'll fix
it.
