On 2/15/23 01:26, Philippe Mathieu-Daudé wrote:
"hw/ide.h" is a mixed bag of lost IDE declarations.Extract isa_ide_init() and the TYPE_ISA_IDE QOM declarations to a new "hw/ide/isa.h" header. Rename ISAIDEState::isairq as 'irqnum' to emphasize this is not a qemu_irq object but the number (index) of an ISA IRQ.
This is fine, but should be separate from the header creation. With the split, for both patches, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~