On 2/3/23 12:24, Alex Bennée wrote:

Peter Maydell <peter.mayd...@linaro.org> writes:

On Wed, 1 Mar 2023 at 19:47, Alex Bennée <alex.ben...@linaro.org> wrote:

 From the other thread:

I think the underlying config needs updating:

   .git/modules/tests/fp/berkeley-testfloat-3/config

I'm surprised the git config for submodules doesn't carry the metadata.

Yeah, in my local repo that I merge stuff with that file
does still have a github URL:
url = git://github.com/cota/berkeley-testfloat-3

So I guess my questions are:
  (1) why hasn't this been a problem up til now ?

Well this is the first time we've had to tweak testfloat since Emilio
introduced it when we first added the fp tests.

  (2) does this mean that if I merge this then everybody will
      need to manually go in and update this file somehow
      to be able to pull the updated qemu master ?

It will depend on how old their checkout is. I don't know why git does
just honour the metadata in .git-submodules - maybe there is a command
line stanza to reset the origin repo of submodules?

   git submodule [--quiet] sync [--recursive] [--] [<path>...]

   Synchronizes submodules' remote URL configuration setting to
   the value specified in .gitmodules. It will only affect those
   submodules which already have a URL entry in .git/config (that
   is the case when they are initialized or freshly added). This
   is useful when submodule URLs change upstream and you need to
   update your local repositories accordingly.

   If --recursive is specified, this command will recurse into the
   registered submodules, and sync any nested submodules within.

Reply via email to