Hi On Mon, Mar 6, 2023 at 8:06 PM Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Mon, 6 Mar 2023 at 12:33, <marcandre.lur...@redhat.com> wrote: > > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Make the resulting code even prettier, if possible. > > This seems to be a bit short on rationale. This is generated > code, so in general nobody is going to be reading it, and > running clang-format on it every time we generate code feels > like it would be a bit of a waste of cycles...
With this reasoning, why do we care about indentation of generated code at all? I think it still makes sense, because you have many reasons to read through it eventually, and making it a bit more friendly helps. Whether it is a waste of time or not, hmm. Indeed, my experience with clang-format has teached me that it is not the most CPU-friendly sometimes... Perhaps the solution is only to enable formatting when debugging is enabled, for example? -- Marc-André Lureau
