On 20.04.23 11:33, Lukas Straub wrote:
On Thu, 20 Apr 2023 01:52:28 +0300
Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> wrote:
Hi all!
COLO substem seems to be useless when CONFIG_REPLICATION is unset, as we
simply don't allow to set x-colo capability in this case. So, let's not
compile in unreachable code and interface we cannot use when
CONFIG_REPLICATION is unset.
Also, provide personal configure option for COLO Proxy subsystem.
v1 was
[PATCH] replication: compile out some staff when replication is not configured
Supersedes: <20230411145112.497785-1-vsement...@yandex-team.ru>
Hey,
This series is a good idea, and looks fine to me. Maybe you can remove
the #ifdef CONFIG_REPLICATION/#ifndef CONFIG_REPLICATION from
migration/colo.c too while you are at it.
Oh, right, will do in v3. Thanks!
--
Best regards,
Vladimir
