Re: [PATCH v2 3/5] migration: Teach dirtyrate about qemu_target_page_size()

[Philippe Mathieu-Daudé]

On 11/5/23 16:12, Juan Quintela wrote:

Signed-off-by: Juan Quintela <quint...@redhat.com>
---
  migration/dirtyrate.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 38ea95af59..6706e3fe66 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -314,10 +314,10 @@ static void update_dirtyrate(uint64_t msec)
  static uint32_t get_ramblock_vfn_hash(struct RamblockDirtyInfo *info,
                                        uint64_t vfn)
  {
+    int page_size = qemu_target_page_size();

size_t? Otherwise,

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

      uint32_t crc;

- crc = crc32(0, (info->ramblock_addr +

-                vfn * TARGET_PAGE_SIZE), TARGET_PAGE_SIZE);
+    crc = crc32(0, info->ramblock_addr + vfn * page_size, page_size);

trace_get_ramblock_vfn_hash(info->idstr, vfn, crc);

      return crc;