On 2012-02-09 10:58, David Gibson wrote: > On Thu, Feb 09, 2012 at 09:30:09AM +0100, Jan Kiszka wrote: >> Looks like the subject would warmly welcome a "kvm:" tag. >> >> On 2012-02-09 05:22, David Gibson wrote: > [snip] >> >> What about naming the problem instead: >> >> /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. */ > > Just once, it would be nice to post something to this list and get a > substantive comment _before_ the bitching about minutiae. > > Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)==4, > which includes ppc64 amongst other 64-bit hosts.
Then state "if int is 32 bits". The comment is unfortunately not helpful without the commit log. Jan
signature.asc
Description: OpenPGP digital signature
