Peter Maydell <peter.mayd...@linaro.org> writes:
> On Fri, 23 Jun 2023 at 13:21, Alex Bennée <alex.ben...@linaro.org> wrote: >> >> We can return XKB_MOD_INVALID which rightly gets flagged by sanitisers >> as an overly wide shift attempt. >> >> Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > > Same comments as on the first version of this patch: > looks OK code-wise, but have you eyeballed the output? I've eyeballed it but practically it doesn't seem to make any difference to the output: 🕙21:20:36 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/22) [$!?] ➜ diff -ub gb.before gb.after 🕙21:20:43 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/22) [$!?] ➜ diff -ub ara.before ara.after > Does the keyboard layout that triggers this have no > AltGr at all, or does it call it by a different name? Certainly not ara or gb: 9: Alt 23:# 11: LAlt 24:# 12: RAlt 29:# 17: AltGr 294:Alt_L 0x38 1711:Alt_R 0xb8 🕙21:22:14 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/22) [$!?] ➜ ag "Alt" gb.after 21:# 9: Alt 23:# 11: LAlt 24:# 12: RAlt 29:# 17: AltGr 338:Alt_L 0x38 1757:Alt_R 0xb8 > > thanks > -- PMM -- Alex Bennée Virtualisation Tech Lead @ Linaro
