Re: [PATCH v4 2/5] vfio/pci: Free leaked timer in vfio_realize error path

[Cédric Le Goater]

On 6/29/23 10:40, Zhenzhong Duan wrote:

When vfio_realize fails, the mmap_timer used for INTx optimization
isn't freed. As this timer isn't activated yet, the potential impact
is just a piece of leaked memory.

Fixes: ea486926b07d ("vfio-pci: Update slow path INTx algorithm timer related")
Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com>

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.

---
  hw/vfio/pci.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 48df517f79ee..ab6645ba60af 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3224,6 +3224,9 @@ out_deregister:
      if (vdev->irqchip_change_notifier.notify) {
          kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_notifier);
      }
+    if (vdev->intx.mmap_timer) {
+        timer_free(vdev->intx.mmap_timer);
+    }
  out_teardown:
      vfio_teardown_msi(vdev);
      vfio_bars_exit(vdev);