>-----Original Message----- >From: Cédric Le Goater <c...@redhat.com> >Sent: Friday, June 30, 2023 12:40 AM >Subject: Re: [PATCH v4 5/5] vfio/migration: Refactor and fix print of >"Migration >disabled" > >Hello Zhenzhong, > >On 6/29/23 10:40, Zhenzhong Duan wrote: >> This patch refactors vfio_migration_realize() and its dependend code >> as follows: >> >> 1. It's redundant in vfio_migration_realize() to registers multiple blockers, >> e.g: vIOMMU blocker can be refactored as per device blocker. >> 2. Change vfio_viommu_preset() to be only a per device checker. >> 3. Remove global vIOMMU blocker related stuff, e.g: >> giommu_migration_blocker, vfio_[block|unblock]_giommu_migration() >> and vfio_migration_finalize() >> 4. Change vfio_migration_realize(), vfio_block_multiple_devices_migration() >> vfio_block_migration() and vfio_viommu_preset() to return bool type. >> 5. Print "Migration disabled" depending on enable_migration property >> and print it as warning instead of error which is overkill. > > >We are close to soft freeze and these combo patches adding various fixes all >at once are difficult to evaluate. > >Please split this patch in multiple ones to ease the review. May be start with >the int -> bool conversion of the return values. It should remove some noise. Good suggestion! Will do.
Thanks Zhenzhong
