>-----Original Message----- >From: Joao Martins <joao.m.mart...@oracle.com> >Sent: Friday, June 30, 2023 7:17 PM >Subject: Re: [PATCH v5 5/7] vfio/migration: Change vIOMMU blocker from >global to per device > >On 30/06/2023 08:36, Zhenzhong Duan wrote: >> vIOMMU migration blocker can be consolidated to per device default >> blocker, then some vIOMMU global blocker related functions and data >> could be removed. >> >Perhaps expand to something like below on the why it justifies the >consolidation: > >Contrary to multiple device blocker which needs to consider already-attached >devices to unblock/block dynamically, the vIOMMU migration blocker is a >device >specific config. Meaning it only needs to know whether the device is bypassing >or not the vIOMMU (via machine property, or per pxb-pcie::bypass_iommu), >and >does not need the state of currently present devices. For this reason, the >vIOMMU global migration blocker can be consolidated into the per-device >migration blocker, allowing us to remove some unnecessary code. Great, will use this words.
Thanks Zhenzhong