Hi
Daniel, in commit 275e0d616b ("ui: refactor code for populating
SocketAddress from vnc_display_open"), you said "This refactoring also
removes the restriction that prevents enabling websockets when the plain
VNC server is listening on a UNIX socket.". But you didn't remove the
condition. I suppose it was a left-over?
On Mon, Jul 24, 2023 at 1:59 AM Sergii Zasenko <ser...@zasenko.name> wrote:
> Signed-off-by: Sergii Zasenko <ser...@zasenko.name>
>
lgtm
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> ui/vnc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 92964dc..dea1414 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3715,11 +3715,6 @@ static int vnc_display_get_address(const char
> *addrstr,
> addr->type = SOCKET_ADDRESS_TYPE_UNIX;
> addr->u.q_unix.path = g_strdup(addrstr + 5);
>
> - if (websocket) {
> - error_setg(errp, "UNIX sockets not supported with websock");
> - goto cleanup;
> - }
> -
> if (to) {
> error_setg(errp, "Port range not support with UNIX socket");
> goto cleanup;
> --
> 2.39.2
>
>
>
--
Marc-André Lureau
