It is common to support MPAM on CPU cores, but not in the rest of the system, so there is little disadvantage in always enabling these.
Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com> --- target/arm/cpu.h | 15 +++++++++++++++ target/arm/cpu.c | 10 +++++++++- target/arm/helper.c | 30 ++++++++++++++++++++++++++++++ 3 files changed, 54 insertions(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 88e5accda6..8d28e22291 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -735,6 +735,10 @@ typedef struct CPUArchState { * to keep the offsets into the rest of the structure smaller. */ ARMVectorReg zarray[ARM_MAX_VQ * 16]; + + uint64_t mpam0_el1; + uint64_t mpam1_el1; + #endif struct CPUBreakpoint *cpu_breakpoint[16]; @@ -1043,6 +1047,7 @@ struct ArchCPU { uint64_t id_aa64zfr0; uint64_t id_aa64smfr0; uint64_t reset_pmcr_el0; + uint64_t mpamidr_el1; } isar; uint64_t midr; uint32_t revidr; @@ -2327,6 +2332,16 @@ FIELD(DBGDEVID, DOUBLELOCK, 20, 4) FIELD(DBGDEVID, AUXREGS, 24, 4) FIELD(DBGDEVID, CIDMASK, 28, 4) +FIELD(MPAMIDR, PARTID_MAX, 0, 16) +FIELD(MPAMIDR, HAS_HCR, 17, 1) +FIELD(MPAMIDR, VMR_MAX, 18, 3) +FIELD(MPAMIDR, PMG_MAX, 32, 8) +FIELD(MPAMIDR, HAS_ALTSP, 57, 1) +FIELD(MPAMIDR, HAS_TIDR, 58, 1) +FIELD(MPAMIDR, SP4, 59, 1) +FIELD(MPAMIDR, HAS_FORCE_NS, 60, 1) +FIELD(MPAMIDR, HAS_SDEFLT, 61, 1) + FIELD(MVFR0, SIMDREG, 0, 4) FIELD(MVFR0, FPSP, 4, 4) FIELD(MVFR0, FPDP, 8, 4) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 93c28d50e5..d85a3ec8a2 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -305,6 +305,9 @@ static void arm_cpu_reset_hold(Object *obj) env->cp15.rvbar = cpu->rvbar_prop; env->pc = env->cp15.rvbar; #endif + + env->mpam1_el1 = 1ULL << 63; + } else { #if defined(CONFIG_USER_ONLY) /* Userspace expects access to cp10 and cp11 for FP/Neon */ @@ -2097,7 +2100,12 @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp) FIELD_DP32(cpu->isar.id_pfr0, ID_PFR0, AMU, 0); /* FEAT_MPAM (Memory Partitioning and Monitoring Extension) */ cpu->isar.id_aa64pfr0 = - FIELD_DP64(cpu->isar.id_aa64pfr0, ID_AA64PFR0, MPAM, 0); + FIELD_DP64(cpu->isar.id_aa64pfr0, ID_AA64PFR0, MPAM, 1); + cpu->isar.mpamidr_el1 = + FIELD_DP64(cpu->isar.mpamidr_el1, MPAMIDR, PARTID_MAX, 63); + cpu->isar.mpamidr_el1 = + FIELD_DP64(cpu->isar.mpamidr_el1, MPAMIDR, PMG_MAX, 3); + /* FEAT_NV (Nested Virtualization) */ cpu->isar.id_aa64mmfr2 = FIELD_DP64(cpu->isar.id_aa64mmfr2, ID_AA64MMFR2, NV, 0); diff --git a/target/arm/helper.c b/target/arm/helper.c index 50f61e42ca..dbeb8d9fa6 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -8072,7 +8072,17 @@ static const ARMCPRegInfo actlr2_hactlr2_reginfo[] = { .access = PL2_RW, .type = ARM_CP_CONST, .resetvalue = 0 }, }; +/* +static uint64_t mpam_el1_read(CPUARMState *env, const ARMCPRegInfo *ri) +{ + return 0; +} +static void mpam_el1_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t val) +{ + return; +} +*/ void register_cp_regs_for_features(ARMCPU *cpu) { /* Register all the coprocessor registers based on feature bits */ @@ -8404,6 +8414,26 @@ void register_cp_regs_for_features(ARMCPU *cpu) .access = PL1_R, .type = ARM_CP_CONST, .accessfn = access_aa64_tid3, .resetvalue = 0 }, + + /* Should be separate feature */ + { .name = "MPAMIDR_EL1", .state = ARM_CP_STATE_AA64, + .opc0 = 3, .opc1 = 0, .crn = 0xa, .crm = 4, .opc2 = 4, + .access = PL1_R, .type = ARM_CP_CONST, + .accessfn = access_aa64_tid3, + .resetvalue = cpu->isar.mpamidr_el1 }, + /* TODO: check the accessfn and whether we need a reset value for these */ + { .name = "MPAM0_EL1", .state = ARM_CP_STATE_AA64, + .opc0 = 3, .opc1 = 0, .crn = 0xa, .crm = 5, .opc2 = 1, + .access = PL1_RW, .type = ARM_CP_ALIAS, + .accessfn = access_aa64_tid3, + .fieldoffset = offsetof(CPUARMState, mpam0_el1), + }, + { .name = "MPAM1_EL1", .state = ARM_CP_STATE_AA64, + .opc0 = 3, .opc1 = 0, .crn = 0xa, .crm = 5, .opc2 = 0, + .access = PL1_RW, .type = ARM_CP_ALIAS, + .accessfn = access_aa64_tid3, + .fieldoffset = offsetof(CPUARMState, mpam1_el1), + }, { .name = "MVFR0_EL1", .state = ARM_CP_STATE_AA64, .opc0 = 3, .opc1 = 0, .crn = 0, .crm = 3, .opc2 = 0, .access = PL1_R, .type = ARM_CP_CONST, -- 2.39.2