On 8/10/23 7:34 PM, Philippe Mathieu-Daudé wrote:
Hi,
On 10/8/23 09:42, xianglai li wrote:
1.Add edk2-platform submodule
2.Added loongarch UEFI BIOS support to compiled scripts.
3.The cross-compilation toolchain on x86 can be obtained from the
link below:
https://github.com/loongson/build-tools/tree/2022.09.06
Cc: Paolo Bonzini <pbonz...@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lur...@redhat.com>
Cc: "Daniel P. Berrangé" <berra...@redhat.com>
Cc: Thomas Huth <th...@redhat.com>
Cc: "Philippe Mathieu-Daudé" <phi...@linaro.org>
Cc: Gerd Hoffmann <kra...@redhat.com>
Cc: Xiaojuan Yang <yangxiaoj...@loongson.cn>
Cc: Song Gao <gaos...@loongson.cn>
Cc: Bibo Mao <maob...@loongson.cn>
Signed-off-by: xianglai li <lixiang...@loongson.cn>
---
.gitmodules | 3 +++
meson.build | 2 +-
pc-bios/meson.build | 2 ++
roms/edk2-build.config | 14 ++++++++++++++
roms/edk2-build.py | 4 ++--
roms/edk2-platforms | 1 +
6 files changed, 23 insertions(+), 3 deletions(-)
create mode 160000 roms/edk2-platforms
diff --git a/.gitmodules b/.gitmodules
index 73cae4cd4d..0cb57123fa 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -43,3 +43,6 @@
[submodule "tests/lcitool/libvirt-ci"]
path = tests/lcitool/libvirt-ci
url = https://gitlab.com/libvirt/libvirt-ci.git
+[submodule "roms/edk2-platforms"]
+ path = roms/edk2-platforms
+ url = https://github.com/tianocore/edk2-platforms.git
See "Topic 4" in [*].
> We do need to be careful about GPL compliance (making sure users
> have the source if we provide them the compiled firmware blob
> for a GPL'd piece of firmware); but we don't need to necessarily
> ship the sources in the exact same tarball as the blob.
> [...]
> Users of QEMU from git don't get a great firmware experience either,
> since the firmware is in submodules, with all the usual git submodule
> problems.
edk2-platforms.git use the same license than edk2.git,
BSD-2-Clause-Patent, which is compatible with GPLv2. At least this is not
edk2-non-osi.git.
Still, we should discuss this generic issue before going forward with
this patch IMO.
Okay, I also think that there is no need to include EDK2 source code in
the tar ball,
you can package the git repository of QEMU for distribution,
and compile the BIOS binary package before release,
so that there is no need to include BIOS code,
QEMU users can also get the source code of BIOS through Git Submodule.
This is only my opinion, and I look forward to the outcome of the final
discussion.
Thanks,
xianglai
Regards,
Phil.
[*]
https://lore.kernel.org/qemu-devel/cafeaca_rzibuswgj9cg9m1ps5png58eyim+_p9hmu5nf7g7...@mail.gmail.com/
