On 18/09/2023 22:41, Markus Armbruster wrote: > Functions that use an Error **errp parameter to return errors should > not also report them to the user, because reporting is the caller's > job. When the caller does, the error is reported twice. When it > doesn't (because it recovered from the error), there is no error to > report, i.e. the report is bogus. > > qio_channel_rdma_writev() violates this principle: it calls > error_report() via qemu_rdma_exchange_send(). I elected not to > investigate how callers handle the error, i.e. precise impact is not > known. > > Clean this up by converting qemu_rdma_exchange_send() to Error. > > Necessitates setting an error when qemu_rdma_post_recv_control(), > callback(), or qemu_rdma_exchange_get_response() failed. Since these > errors will go away later in this series, simply use "FIXME temporary > error message" there. > > Signed-off-by: Markus Armbruster<arm...@redhat.com>
Reviewed-by: Li Zhijian <lizhij...@fujitsu.com>
