Cédric Le Goater <c...@kaod.org> writes: > On 9/23/23 09:13, Markus Armbruster wrote: >> Cédric Le Goater <c...@kaod.org> writes: >> >>> On 9/22/23 20:20, Philippe Mathieu-Daudé wrote: >>>> On 22/9/23 17:59, Cédric Le Goater wrote: >>>>> Hello, >>>>> >>>>> Here are cleanups for local variable shadowing warnings in aspeed models. >>>>> >>>>> Joel, Andrew, >>>>> >>>>> Could you please double check patch 4 ? >>>> Could Markus' MAKE_IDENTFIER() help there? >>> >>> ah ! you typed too fast and I also read too fast, as : >>> >>> MARKUS_IDENTIFIER() >>> >>> and I liked it :) >> >> LOL >> >>> but what is MAKE_IDENTIFIER ? really, please explain. >> >> Philippe is referring to >> >> [PATCH v3 7/7] qobject atomics osdep: Make a few macros more hygienic >> Message-ID: <20230921121312.1301864-8-arm...@redhat.com> >> >> which tweaks MAX() to permit nesting without shadowing. Your PATCH 4 >> may not be needed if you base on it. > > We don't need the nested MAX(). PATCH 4 is a cleanup which happens > to remove the shadowing. Let's keep it the way it is. > >> MAKE_IDENTIFIER() is a helper macro introduced in that patch. >> You can fetch the patch from https://repo.or.cz/qemu/armbru.git branch >> shadow-next, along with collected other shadowing patches. > > OK. > > Would you prefer maintainers to include the shadowing changes in a > potential PR they would send or would you rather take care of it in > a PR of your own ?
I'm happy to collect patches and do pull requests. I don't mind maintainers merging patches for their subsystems; interference should be minimal. Thanks!
