On 9/25/23 21:04, Peter Maydell wrote:
The include of hw/arm/virt.h in kvm64.c is unnecessary and also a
layering violation since the generic KVM code shouldn't need to know
anything about board-specifics.  The include line is an accidental
leftover from commit 15613357ba53a4763, where we cleaned up the code
to not depend on virt board internals but forgot to also remove the
now-redundant include line.

Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
---
  target/arm/kvm64.c | 1 -
  1 file changed, 1 deletion(-)


Reviewed-by: Gavin Shan <gs...@redhat.com>

diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index 5e95c496bb9..3ea9f1d6743 100644
--- a/target/arm/kvm64.c
+++ b/target/arm/kvm64.c
@@ -30,7 +30,6 @@
  #include "internals.h"
  #include "hw/acpi/acpi.h"
  #include "hw/acpi/ghes.h"
-#include "hw/arm/virt.h"
static bool have_guest_debug;


Reply via email to