On 10/4/23 09:46, Stefan Hajnoczi wrote:
On Wed, 4 Oct 2023 at 12:28, Richard Henderson
<richard.hender...@linaro.org> wrote:
On 10/4/23 07:57, Stefan Hajnoczi wrote:
This commit breaks the build:
../bsd-user/signal.c:479:19: error: unused variable 'env'
[-Werror,-Wunused-variable]
CPUArchState *env = cpu_env(cpu);
^
https://gitlab.com/qemu-project/qemu/-/jobs/5222693462
Please resend the pull request with a fix.
The line number quoted above does not correspond to my source.
Did you attempt to merge multiple pulls simultaneously?
There must be a conflict between them.
My guess is Warner's bsd-user PR.
Please just apply that first and I'll re-roll mine afterward.
Okay. Note that host_signal_handler()'s env local variable looks
unused in your tag:
https://gitlab.com/rth7680/qemu/-/blob/pull-tcg-20231003/bsd-user/signal.c?ref_type=tags#L473
You're right, it does appear to be unused.
And yet "make vm-build-freebsd" succeeds, as does a native build on a freebsd
install.
r~
