On 2012-02-28 23:18, Stefan Weil wrote: > Am 17.02.2012 16:45, schrieb Jan Kiszka: >> In case we requeued a packet that was the head of a longer session >> queue, we failed to restore this ordering. Also, we did not properly >> deal with changes to Slirp::next_m. >> >> Instead of a cumbersome roll back, this fix simply avoids any changes >> until we know if the packet was actually sent. Both fixes crashes due >> to inconsistent queues and simplifies the logic. >> >> Thanks to Zhi Yong Wu who found the reason for these crashes. >> >> CC: Zhi Yong Wu <wu...@linux.vnet.ibm.com> >> CC: Fabien Chouteau <chout...@adacore.com> >> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> >> --- >> slirp/if.c | 35 +++++++++++++++++++---------------- >> 1 files changed, 19 insertions(+), 16 deletions(-) > > Latest QEMU crashed here 4 times with MIPS Malta > when I tried 'apt-get update' in the guest. See gdb output > below for details. > > I only got the crash with big endian MIPS, not with little > endian which is strange. > > After I reverted the above patch, MIPS Malta worked > again as before. > > So maybe we changed one crash against a new one.
Could you retry with git://git.kiszka.org/qemu.git queues/slirp ? TIA, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
