On 28.02.2012 18:41, Luiz Capitulino wrote: >> Hmm, I know Michal already sent a new version with my suggestions, but >> > you're right, splitting out the commands simplified both the responses, >> > and makes it easier to discover whether or not that information is >> > available, since you can look for the command in guest-info before >> > attempting it, rather than attempting it and then looking at the result. >> > >> > So maybe just something this?: >> > >> > { 'type': 'GuestNetworkInterface', >> > 'data': { 'name': 'str', >> > '*hardware-address': 'str', >> > '*ip-addresses': ['GuestIpAddress'] } } } >> > >> > { 'command': 'guest-network-interfaces', >> > 'returns': ['GuestNetworkInterface'] } > Looks good to me, the only nitpick is that I think command names should be > verbs.
guest-get-network-interfaces?