"Michael S. Tsirkin" <m...@redhat.com> writes: > On Thu, Oct 12, 2023 at 02:18:44PM +0200, Markus Armbruster wrote: >> Thomas Huth <th...@redhat.com> writes: >> >> > Rename some variables to avoid compiler warnings when compiling >> > with -Wshadow=local. >> > >> > Signed-off-by: Thomas Huth <th...@redhat.com> >> > --- >> > v2: Renamed the variable to something more unique
[...] >> v1 renamed to s_ instead, which I find much easier to read. Michael >> asked you to change it so it's less likely to break if we pass it a >> macro that also uses s_. Unlikely to happen, and would fail safe: build >> breaks. [...] >> I'm going to queue v1. Michael, if you want me to queue v2 instead, or >> neither of the two, let me know. > > Yea I think v2 is better, queue that please. Done. Thanks!
