Hi > On 02 Jun 2015, at 18:15, Nathan Woodrow <madman...@gmail.com> wrote: > > I'm all for strict unit test policy however they need to be able to run on > all platforms consistently in order to enforce that correctly. Taking the > failing PyQgsAppStartup test on Travis, i just ran it on my Linux setup and > it passes fine, yet fails on Travis. I'm skeptical of that test anyway but > it does make it hard to fix when it can't be reproduced.. > > Compare to Traivs I get these two tests failing: > > The following tests FAILED: > 100 - PyQgsLocalServer (Failed) > 134 - PyQgsPalLabelingServer (Failed)
Disabling a test is also a legitimate course of action - if the test does not run as expected and there is no reasonable way to see why in python you can tag it as ‘expected failure’ using the expectedFailure decorator. Obviously that should not be the default action when a test fails and should not be used to disable tests in masse, but disabling the test puts travis back into a testable state for other dev while you figure out the reason for the regression. Regards Tim > > > On Tue, 2 Jun 2015 at 19:31 Matthias Kuhn <matth...@opengis.ch > <mailto:matth...@opengis.ch>> wrote: > Hi Jürgen > > On 06/02/2015 09:03 AM, Jürgen E. Fischer wrote: > > Hi Nyall, > > > > On Tue, 02. Jun 2015 at 13:34:56 +1000, Nyall Dawson wrote: > >> I'd be in favour of a hardline "no breaks allowed" approached. You break > >> travis, your commit gets reverted. > > -1 > > > > A general rule doesn't make sense to me - it depends on the break. > > If you break travis, you should fix it. > > For the record, can you elaborate which types of breaks should not be > fixed and/or why certain breaks should be fixed in master instead of in > a separate branch/pull request? > > Regards > Matthias > _______________________________________________ > Qgis-developer mailing list > Qgis-developer@lists.osgeo.org <mailto:Qgis-developer@lists.osgeo.org> > http://lists.osgeo.org/mailman/listinfo/qgis-developer > <http://lists.osgeo.org/mailman/listinfo/qgis-developer> > _______________________________________________ > Qgis-developer mailing list > Qgis-developer@lists.osgeo.org > http://lists.osgeo.org/mailman/listinfo/qgis-developer — Tim Sutton Visit http://kartoza.com <http://kartoza.com/> to find out about open source: * Desktop GIS programming services * Geospatial web development * GIS Training * Consulting Services Skype: timlinux Irc: timlinux on #qgis at freenode.net Tim is a member of the QGIS Project Steering Committee Kartoza is a merger between Linfiniti and Afrispatial
_______________________________________________ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
