On 13 November 2015 at 02:42, Matthias Kuhn <[email protected]> wrote: > Simple answer: don't use rendering tests and find other means to check > it ;-)
Hmm... for something like this (testing rendering of a line style), I think a rendering test is perfectly acceptable! It's only when rendering tests are used for things like checking geometry operations that it's an issue IMO. Nyall > > If you still need, use the MultiRenderChecker, it is based on the > RenderChecker but adds more possibilities for anomalies. At least that's > the latest state of rendering tests I'm aware of... > > Best > > On 11/12/2015 04:37 PM, Sandro Santilli wrote: >> I've found a bug in rendering line-offsetted marker line symbols [1] >> and wondering what's the currently recommended way to add a testcase. >> >> [1] http://hub.qgis.org/issues/13811 or >> https://github.com/qgis/QGIS/pull/2442 >> >> Looking around I see many test files using the QgsRenderChecker >> class in tests/src/core but the rationale is not clear to me. >> >> Here's the list: >> >> regression992.cpp >> testqgsblendmodes.cpp >> testqgscomposerobject.cpp >> testqgscomposerutils.cpp >> testqgsdiagram.cpp >> testqgsgeometry.cpp >> testqgsgradients.cpp >> testqgsimageoperation.cpp >> testqgsinvertedpolygonrenderer.cpp >> testqgslabelingenginev2.cpp >> testqgslegendrenderer.cpp >> testqgslinefillsymbol.cpp >> testqgsmaprenderer.cpp >> testqgsmaprotation.cpp >> testqgspainteffect.cpp >> testqgspointpatternfillsymbol.cpp >> testqgsrasterfill.cpp >> testqgsrasterlayer.cpp >> * testqgsrenderers.cpp >> testqgsshapeburst.cpp >> >> Then other files use the QgsMultiRenderChecker class instead: >> >> qgscompositionchecker.cpp >> testqgsblendmodes.cpp >> testqgsdiagram.cpp >> testqgsinvertedpolygonrenderer.cpp >> testqgspainteffect.cpp >> testqgsrasterfill.cpp >> testqgsrenderers.cpp >> testqgsshapeburst.cpp >> * testqgsstylev2.cpp >> * testqgssymbolv2.cpp >> >> What's the difference between the two classes ? Which one should I use ? >> Should I put the new case in any existing file ? >> (I've tagged the possible candidates with a star) >> >> --strk; >> >> () Free GIS & Flash consultant/developer >> /\ http://strk.keybit.net/services.html >> _______________________________________________ >> Qgis-developer mailing list >> [email protected] >> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer >> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer > > -- > Matthias Kuhn > OPENGIS.ch - https://www.opengis.ch > Spatial • (Q)GIS • PostGIS • Open Source > > > > _______________________________________________ > Qgis-developer mailing list > [email protected] > List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer _______________________________________________ Qgis-developer mailing list [email protected] List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
