Michael Hunger wrote: > Another thing, you put much consideration on having small > classes/fragments doing only one thing (Single Responsibility) but in > the SPI there is a lot of functionality contained in the classes. Are > these just leftovers?
Do you have any specific examples? > What about the curly braces? Could you explain the reasons behind > choosing this c# style? It's purely for readability reasons. Having curly brace blocks on the same level is much more readable than the other way. In general we favor "air" in the code rather than compactness, since the code is going to be read for more often than it is going to be written. Readability is very important. The refactorings you submitted, that introduced methods that explained what was going on, was a good step towards that, and having a "fluffy" code style also helps we think. It's as simple as that. /Rickard _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
