While refactoring I came along the Mixin-, Composite- and FragmentModels and saw that they have tons of constructor parameters. This is very obvious during the construction of these models as there are all those dependencies created upfront and than injected all at once, although all of the depedencies created rely on just one or two base inputs.
Two suggestions, questions: 1. I'd like to replace inheritance for delegation for MixinModel, to reduce its complexity 2. I'd like to supply a constructor or factory method internal to CompositeModel and MixinModel that take the base inputs and to the resolving of all the addtional inputs theirselfes. An alternative would be givin a factory to this creational method/constructor and delegate the concrete tasks to the factory. 3. I'd like to replace the Interable<xxxModel> by real classes and move most of the iteration-methods there. What do you think Michael _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
