Thanks for the commit.

I have two questions

1) Why do you still publish most of the internal state of the models via 
accessor methods? Is there real need for that? 
I thought reverting to the real "business" methods on the model removes the 
need of publishing the internal state of the 
models.

2) What do you think about taking the model classes for instance ParameterModel 
(or CompositeMethodModel) and making it 
an private inner class of the "composite" collection type ParametersModel (or 
CompositeMethodsModel) allowing acces to 
it only through the collection type (including the creation/addition). Creation 
of the collection type perhaps via a 
static factory method.

What do you think?

Michael

Rickard Öberg wrote:
> Hey,
>
> I just committed a first stab at concerns with the new model. Looks
> really pretty, and the general design is still working it seems.
>
> Not much to say, other than that I'll continue with side-effects which
> should be very similar to the concerns implementation.
>
> /Rickard
>
> _______________________________________________
> qi4j-dev mailing list
> [email protected]
> http://lists.ops4j.org/mailman/listinfo/qi4j-dev


_______________________________________________
qi4j-dev mailing list
[email protected]
http://lists.ops4j.org/mailman/listinfo/qi4j-dev

Reply via email to