Michael Hunger wrote: > I may try a round of refactoring this night if you'd like. > > The intent of making the models private is to restrict their external > use/visibility. So that for someone outside the SPI are the methods > used during the lifecycle of constructing the model.
Note that the new model is entirely in runtime, not SPI, so I'm not that worried about "leakage", not right now anyway. There will most likely be interfaces for both API and SPI, to be implemented by the runtime model, so that will be the main point of encapsulation. > By making the > models private you make them part of the internal state of the > collection type. * I looked a bit more detailed on the code and by > now most model types are just used by their collection types > "XxxsModel". Except: * MixinModel (1 outside usage) * > InjectionParameterModel (2x creational blocks that could be extracted > to an "add" method on InjectionsModel) * ParameterModel (heaviliy > used outside in creational code) > > I'll try to refactor these and send you the diff. Alright, do so. I'm continuing with constraints today, and then start with the entities (props and associations), which will to some degree impact at least ParameterModel. /Rickard _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
