On 10/12/11 16:05 , Paul Merlin wrote:
Here are the changes that could impact current users:
<snip>
Here are the new configuration properties for basic http service:
<snip>
Here are the new configuration properties for https service:
<snip>
Here are new "bootstrap features":
<snip>
I'm calling here for remarks, comments, code review and even tests if you happen to have time.
Without having looked at the code, the improvements sound good to me!
BTW, there are things I'd like to add after that: * Full support for VirtualHosts would need to factor out the Jetty Server instance handling to a dedicated Service used by the HttpService mixins.
VirtualHosts stuff would be great! I have been looking into multiple tenancy hosting of Qi4j apps (i.e. one WAR -> many tenants -> many Qi4j app instances), and this could be a good way to support that.
* Bind the Jetty MBeans to the Qi4j Service node would be nice but I don't know JMX enough to do that easily. See in AbstractJettyMixin.activate the use of MBeanContainer from the Jetty codebase.
Let me know what questions you have about this, and I'll see what I can do. There are examples in the code already on how to do this, have you looked at that? (e.g. circuit breakers)
* Remove the use of DefaultServlet by default. None of my use cases needs it to be registered. We could add a convenience method on the JettyAssembler that handle the DefaultServlet registration: JettyAssembler withDefaultServlet();
Agree.
WDYT?
Overall, sounds good! /Rickard _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
