Hey,

Le Jeudi 13 Octobre 2011 11:34:07 Rickard Öberg a écrit :
> On 10/12/11 16:05 , Paul Merlin wrote:
> > * Full support for VirtualHosts would need to factor out the Jetty
> >    Server instance handling to a dedicated Service used by the HttpService
> >    mixins.
> VirtualHosts stuff would be great! I have been looking into multiple
> tenancy hosting of Qi4j apps (i.e. one WAR -> many tenants -> many Qi4j
> app instances), and this could be a good way to support that.

I just pushed vhosts support plus a unit test that hook in the java dns system 
to add test hosts to the QI_351_Improve_library_http branch.


> > * Bind the Jetty MBeans to the Qi4j Service node would be nice but I
> > don't> 
> >    know JMX enough to do that easily. See in
> >    AbstractJettyMixin.activate the use of MBeanContainer from the
> >    Jetty codebase.
> 
> Let me know what questions you have about this, and I'll see what I can
> do. There are examples in the code already on how to do this, have you
> looked at that? (e.g. circuit breakers)

I'll take a look thanks.


> > * Remove the use of DefaultServlet by default. None of my use cases
> > needs
> > 
> >    it to be registered. We could add a convenience method on the
> >    JettyAssembler that handle the DefaultServlet registration:
> >    JettyAssembler withDefaultServlet();
> 
> Agree.

After taking a closer look removing the DefaultServlet makes the resourcePath 
configuration property useless. What I did is that the DefaultServlet is 
registered only if the resourcePath configuration property is set.


> Overall, sounds good!

Thanks.

/Paul

-- 
Paul Merlin - eskatos.github.com

_______________________________________________
qi4j-dev mailing list
[email protected]
http://lists.ops4j.org/mailman/listinfo/qi4j-dev

Reply via email to