Well done Tom for organising the recent releases of qmailadmin!
I have cranked up 1.0.21 on my server and would like to provide some
feedback :
ISSUE 1:
When you add a new forward, the wording that is displayed apon completion is
pretty contorted. eg :
"Alias for Email Account added successfully testme2
[EMAIL PROTECTED]"
It shouldn't say "alias" since you are ditching this concept and are now
creating
everything as forwards. Can I suggest it gets altered to simply be token 152
("Forward Added Successfully"). I looked through the dictionary file, and
couldn't see any better way to write it without going to the hassle of
adding
extra tokens.
I have attached a patch so you can see my suggestion. The patch also
renames the a couple of the columns in the various forwards menus.
Take a look and see if you think the patch is worth incorporating or not.
ISSUE 2:
I think there is going to be some confusion for domain postmasters when
they go to the new v1.0.21's "forwards" menu.
If the domain already has some aliases setup, then the information displayed
on this screen is going to be a bit inconsistent.
For example one of the reasons for ditching aliases was to avoid having
mail copied directly to users maildirs. Now if you go in via v1.0.21 and add
a few forwards for local recipients, you wont be able to tell it apart
from existing entries that are using old alias style delivery. If you are
trying
to setup some fancy per-user stuff like spamassassin, then you are going to
get
inconsistent results because some local users will be getting the old alias
delivery and some will be getting the new forward delivery.
Same deal with the count displayed at the top of the screen. The
count will be inconsistent if you have existing alias delivery local users.
I think the best solution would be to convert any existing alias
deliveries over to be forward deliveries. That would allow all the
delivery and limit stuff to remain consistent.
For sites with a lot of domains/users it really wouldn't be suitable to
have to make these changes by hand. I reckon what we need is
some sort of script that can scan the vpopmail/domains tree and
converts any aliases over to be forwards....
I hope you find my feedback to be of use!
Michael
--- ../qmailadmin-1.0.21/alias.c Thu Jun 5 09:24:00 2003
+++ alias.c Sat Jun 7 10:51:23 2003
@@ -459,8 +459,7 @@
exit(0);
} else {
- sprintf(StatusMessage, "%s %s %s\n", get_html_text("166"),
- Alias, ActionUser);
+ sprintf(StatusMessage, "%s\n", get_html_text("152"));
show_forwards(Username,Domain,Mytime,RealDir);
}
}
--- ../qmailadmin-1.0.21/html/add_forward.html Thu Jun 5 03:02:02 2003
+++ html/add_forward.html Sat Jun 7 10:56:53 2003
@@ -25,7 +25,7 @@
<form
method="post" name="addforward" action="##C/com/adddotqmailnow">
<table cellpadding="0" cellspacing="0" border="0">
<tr>
-
<td align=left><b>##X075</b></td>
+
<td align=left><b>##X106</b></td>
<td> </td>
<td align=left><b>##X305</b></td>
</tr>
--- ../qmailadmin-1.0.21/html/mod_dotqmail.html Thu Jun 5 03:51:06 2003
+++ html/mod_dotqmail.html Sat Jun 7 10:54:13 2003
@@ -21,7 +21,7 @@
<table cellpadding="1"
cellspacing="1" border="0" width="100%">
<tr>
<th>##X106</th>
- <th>##X107</th>
+ <th>##X305</th>
<th>##X072</th>
</tr>
##I
--- ../qmailadmin-1.0.21/html/show_forwards.html Fri Jun 6 04:03:46 2003
+++ html/show_forwards.html Sat Jun 7 11:43:34 2003
@@ -24,8 +24,8 @@
<tr bgcolor="#cccccc">
<th align="center" width=50><font size="2">##X072</font></th>
<th align="center" width=50><font size="2">##X071</font></th>
-
<th align="left"><font size="2">##X075</font></th>
-
<th align="center"><font size="2">##X070</font></th>
+
<th align="left"><font size="2">##X106</font></th>
+
<th align="left"><font size="2">##X305</font></th>
</tr>
<!-- Inserts a four columns row -->
##d
