Hi Alessandro!

Thank you for your patch. I've slightly modified your idea. I've added 
"block" to the separator statements, but I have not extended not_after 
because this will otherwise change the idea behind this list (and I'm 
not sure if this is the correct place). I think the idea from you behind 
this was to omit double semicolon sequences. I've added checks to all 
places to omit such a problem.

I've just committed these changes.

Cheers,

Sebastian



Alessandro Sala schrieb:
> Hi Sebastian,
> 
> I think I've found another treecompiler failure: when a block node is 
> not the
> first (or the only) child of another node, it should be separated from its
> preceding sibling by a semicolon (except when its preceding sibling is a 
> block
> too), but the treecompiler simply attaches the two nodes without any
> separator in between.
> 
> For example:
> 
> var x = 3;
> {
>    var y = 2;
>    x *= y;
> }
> 
> 
> becomes
> 
> var x=3{var y=2;x*=2}
> 
> which produces a syntax error, since it is missing a ";" between "3" and 
> "{".
> 
> I think the simplest solution in include "block" type nodes among
> separators for child nodes. As usual I attach a simple patch for you to
> evaluate and apply if you feel so.
> 
> Cheers,
> Alessandro
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys -- and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> qooxdoo-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to