Hi Fabian, I'm not suprised it's similar to QAction from Qt as I got the idea from the VCL's TAction :)
I'll spend some time creating the patch for the framework before I open the bug. From my calculations we would need to patch qx.event.Command and qx.ui.core.MExecute. BTW: In my design we don't use qx.ui.form.ToggleButton. Instead Command and MExecute include the "autoCheck" and "checked" properties. If autoCheck is true then this.execute() will call this.toggleChecked() before firing the "execute" event. This makes things much nicer as you can then share the same toggle functionality in one command between a "toggle" button, a checkbox and a menu item. I think it might be nicer to use this same design in the framework i.e. qx.ui.form.Button automatically includes the "checked" and "autoCheck" properties and then qx.ui.form.ToggleButton just refines "autoCheck" so it is true by default. As I said, I'll create the patch so you can get a better idea of my proposal and open a bug report for it Thanks, Matt Fabian Jakobs wrote: > Hi Matthew, > > I like this enhancement. It's very similar to the QAction class in Qt > <http://doc.trolltech.com/4.5/qaction.html>. Please open an enhancement > bug for this. Since it requires some changes to our widget I don't know > in which time frame we can address this issue. > > Best Fabian >> Hi All, >> I have created a custom class that extends from qx.event.Command. It >> works in exactly the same way but as well as the "enabled" property it >> also has properties for "label", "icon", "autoCheck", "checked" and >> "menu". The advantage of this is you can create the command once with >> the correct icon and label and then assign it to multiple widgets of >> different types, for example you could have a menu item and a button >> with the same command. >> >> Would any body be interested in this? If so I'll convert it to a patch >> for the original and open an enhancement bug >> > ------------------------------------------------------------------------------ Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
