D'oh! You are right, and I was cracking my head why I didn't get any
exceptions on that. Turns out, after I moved the modules, there were
still the corresponding *.pyc files around that keept my test running :).
Fixed in r22152.
Thanks again,
T.
On 05/07/2010 04:03 PM, Peter Schneider wrote:
> Hi again,
>
> after only one small change in qooxdoo/tool/pylib/generator/Generator.py[1]
> I can report the following:
>
> generate distclean OK
> generate translation OK
> generate source OK (copy & use of combined images)
> generate build OK (copy & use of combined images)
> generate api OK
>
> I did not check all other jobs, but those are the most important ones I
> currently use ;)
>
>
> So again, nice weekend to all of you
> Peter
>
> ---
> [1] A simpe wrong path patch:
> - from generator.action.ImageInfo import ImgInfoFmt
> + from generator.resource.ImageInfo import ImgInfoFmt
>
>
>
> On 2010-05-07 15:56 Peter Schneider wrote:
>> Hi Thomas,
>>
>> thanks for your effort, but the current trunk is not working at all.
>> Neither does r22147. I think its 'cause of the "re-org name spaces" in
>> rev 22142-22146...
>> Therefore I have to merge a little bit more manual...
>>
>> I think I can manage to fix those issues I have here, but I can not yet
>> confirm
>> whether your fix does fix the original issue...
>>
>> "Don't panic!"(TM) ;)
>>
>> Currently it seems that the import paths seem to be off, but I have not
>> really
>> looked at it in detail.
>>
>> Nevertheless, nice weekend to all of you
>> Peter
>>
>>
>> On 2010-05-07 15:21 thron7 wrote:
>>> I've added another commit (r22147), hopefully this finishes it off. But
>>> this time multiple files are affected, so make sure you update all of
>>> them. - Thanks for bringing this up agin.
>>>
>>> T.
>>>
>>> On 05/06/2010 04:36 PM, thron7 wrote:
>>>> You're right, I'll have a look at it.
>>>>
>>>> T.
>>>>
>>>> On 05/06/2010 02:42 PM, Peter Schneider wrote:
>>>>> Hi Thomas,
>>>>>
>>>>> sorry, but I can't say that it works...
>>>>> After this command-sequence:
>>>>>
>>>>> generate distclean
>>>>> generate build
>>>>>
>>>>> My "combined images" are not copied into the build/resource/... folder.
>>>>>
>>>>>
>>>>> Or do I have to patch any other files than
>>>>> "trunk/qooxdoo/tool/pylib/generator/action/CodeGenerator.py" ?
>>>>> I chose r22131 'cause it currently is the most current commit with
>>>>> bug#3649
>>>>>
>>>>> /Peter
>>>>>
>>>>> On 2010-05-06 14:36 thron7 wrote:
>>>>>> Checked in a new patch (r22127).
>>>>>>
>>>>>> T.
>>>>>>
>>>>>> On 05/05/2010 03:23 PM, Peter Schneider wrote:
>>>>>>> Hi Thomas,
>>>>>>>
>>>>>>> sorry to re-open this again, but I think the 'generate build' job does
>>>>>>> not
>>>>>>> handle the combined images correct.
>>>>>>> The generated (build-)script tries to load the combined images, but the
>>>>>>> generator did not copy the resources!
>>>>>>>
>>>>>>> So, I still have to keep the "#asset(infodesk/*-combined.png)" line in
>>>>>>> my
>>>>>>> modules to be able to create a deployable "build-version".
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Peter
>>>>>>>
>>>>>>>
>>>>>>> On 2010-05-05 15:15 Peter Schneider wrote:
>>>>>>>> I checked your commit (rev22101,22102 from trunk) and can confirm that
>>>>>>>> it is no
>>>>>>>> longer needed to add any extra "#asset(foo/bar/icon-combined.png)" to
>>>>>>>> the
>>>>>>>> source! So -from my point of view- you can merge it into the 1.1.x
>>>>>>>> branch :-D
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Peter
>>>>>>>>
>>>>>>>> On 2010-05-03 11:35 thron7 wrote:
>>>>>>>>> I checked in a commit that is supposed to fix this, so you don't have
>>>>>>>>> to
>>>>>>>>> specify your combined images in #asset hints anymore. - Give it a go:
>>>>>>>>> rev22102.
>>>>>>>>>
>>>>>>>>> T.
>>>>>>>>>
>>>>>>>>> On 04/29/2010 11:03 AM, Peter Schneider wrote:
>>>>>>>>>> Thank you Thomas,
>>>>>>>>>> adding the combined images to the #assets did the trick!
>>>>>>>>>>
>>>>>>>>>> /Peter
>>>>>>>>>>
>>>>>>>>>> On 2010-04-29 11:00 thron7 wrote:
>>>>>>>>>>> I found it: The problem is in the way combined images are subjected
>>>>>>>>>>> to
>>>>>>>>>>> #asset hints. They have to be included :-\ .
>>>>>>>>>>>
>>>>>>>>>>> So, for the time being you have to #asset them, either by a wild
>>>>>>>>>>> card
>>>>>>>>>>> that includes them (e.g. #asset(infodesk/*)), or explicitly:
>>>>>>>>>>>
>>>>>>>>>>> #asset(infodesk/flag-combined.png)
>>>>>>>>>>> #asset(infodesk/icon/icon16-combined.png)
>>>>>>>>>>> #asset(infodesk/icon/icon32-combined.png)
>>>>>>>>>>>
>>>>>>>>>>> Then it works as expected. I consider this a bug, and have opened a
>>>>>>>>>>> report for it (bug#3649).
>>>>>>>>>>>
>>>>>>>>>>> Sorry for the hassle.
>>>>>>>>>>> T.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 04/28/2010 09:39 AM, Peter Schneider wrote:
>>>>>>>>>>>>> On 04/27/2010 05:51 PM, Peter Schneider wrote:
>>>>>>>>>>>>>> Hi there,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I'm currently trying to combine some images with the help of the
>>>>>>>>>>>>>> generator
>>>>>>>>>>>>>> using the documentation on [1] & [2].
>>>>>>>>>>>>>> The combining itself seems to work (the combined images and the
>>>>>>>>>>>>>> "meta"-files
>>>>>>>>>>>>>> get created), but the application doesn't care about this.
>>>>>>>>>>>>> You did re-run 'generate.py source/build' after creating the
>>>>>>>>>>>>> combined
>>>>>>>>>>>>> images, did you?!
>>>>>>>>>>>> Yes I did.
>>>>>>>>>>>> And by the way, my "config.json" is located where the "image.json"
>>>>>>>>>>>> is located
>>>>>>>>>>>> (see attached zip in my previous post).
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>> What do I have to do to let the application load the combined
>>>>>>>>>>>>>> image instead of
>>>>>>>>>>>>>> the "original" files, Or does this only work for "themed"
>>>>>>>>>>>>>> widgets?
>>>>>>>>>>>>> Nothing, and no.
>>>>>>>>>>>> That was what I'd expected ;)
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>> For an overview (hopefully ;) ) here's my process/problem:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> 1. I'd like to combine groups of my Toolbar Icons into one image.
>>>>>>>>>>>>>> (in my case: one for 32x32 sized icons, one for 16x16 sized
>>>>>>>>>>>>>> icons and one
>>>>>>>>>>>>>> for some flags)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> 2. I made a configuration (see attachment "image.json")
>>>>>>>>>>>>>> according to [1]...
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> 3. I ran "generate -c image.json image-combine" and that did
>>>>>>>>>>>>>> what I expected
>>>>>>>>>>>>>> (the combined files and the meta-files looking good, from
>>>>>>>>>>>>>> what I can say)
>>>>>>>>>>>>>> [Side-note: the command line snippets on [1] use
>>>>>>>>>>>>>> "./generator" instead of
>>>>>>>>>>>>>> "./generate" ...small issue ;) ]
>>>>>>>>>>>>> Thanks. Fixed in 1.1 manual.
>>>>>>>>>>>> Should also be fixed in 1.0 manual, shouldn't it?
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>> 4. But the application (neither the 'build' nor the 'source'
>>>>>>>>>>>>>> version) does not
>>>>>>>>>>>>>> even contain any reference to any of those combined images...
>>>>>>>>>>>>> So what is the observed behaviour? Is your app using the
>>>>>>>>>>>>> individual
>>>>>>>>>>>>> images alright? Which browser do you test with?
>>>>>>>>>>>> The application ('source'- and 'build'-version) works perfectly
>>>>>>>>>>>> with individual
>>>>>>>>>>>> images.
>>>>>>>>>>>> I do my tests with FF 3.6.3 (+firebug) on Windows XP.
>>>>>>>>>>>> The combined images of the framework do work (e.g.
>>>>>>>>>>>> "arrows-combined.png" is
>>>>>>>>>>>> loaded), so I don't think it's a Browser/OS issue.
>>>>>>>>>>>>
>>>>>>>>>>>> As I mentioned, the generated application scripts do not contain
>>>>>>>>>>>> anything like
>>>>>>>>>>>> "infodesk/flag-combined.png"...
>>>>>>>>>>>>
>>>>>>>>>>>> My guess is, that there's a misconfiguration at the paths
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>> 5. All images have been noted in the "#asset"s, but they are not
>>>>>>>>>>>>>> directly used
>>>>>>>>>>>>>> in any image-constructor. So there's no line like this
>>>>>>>>>>>>>> <code>
>>>>>>>>>>>>>> var foo = new qx.ui.toolbar.Button("foo",
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> "infodesk/icon/32/preferences.png");
>>>>>>>>>>>>>> </code>
>>>>>>>>>>>>>> I'm using a 'indirection' like this:
>>>>>>>>>>>>>> <code>
>>>>>>>>>>>>>> var foo_config = {txt:"foo",
>>>>>>>>>>>>>> ico:"infodesk/icon/32/preferences.png");
>>>>>>>>>>>>>> var foo = new qx.ui.toolbar.Button(foo_config.txt,
>>>>>>>>>>>>>> foo_config.ico);
>>>>>>>>>>>>>> </code>
>>>>>>>>>>>>>> But I don't think _this_ is the problem...
>>>>>>>>>>>>> If it works without combined images, it should continue to work
>>>>>>>>>>>>> with them.
>>>>>>>>>>>> That's what I'd expected ;)
>>>>>>>>>>>>
>>>>>>>>>>>> The application just doesn't contain any reference to my combined
>>>>>>>>>>>> images in the
>>>>>>>>>>>> qx.$$resources = {...} section, just the individual images are
>>>>>>>>>>>> noted there.
>>>>>>>>>>>> I would have expected:
>>>>>>>>>>>> <code>
>>>>>>>>>>>> qx.$$resources =
>>>>>>>>>>>> {...,"infodesk/flag_client.png":[21,13,"png","infodesk","infodesk/flag-combined.png",0,-13],...}
>>>>>>>>>>>> </code>
>>>>>>>>>>>>
>>>>>>>>>>>> but the generated script just has this:
>>>>>>>>>>>> <code>
>>>>>>>>>>>> qx.$$resources =
>>>>>>>>>>>> {...,"infodesk/flag_client.png":[21,13,"png","infodesk"],...}
>>>>>>>>>>>> </code>
>>>>>>>>>>>>
>>>>>>>>>>>> So again, I believe I did not get the thing with "prefix" and/or
>>>>>>>>>>>> "files" right
>>>>>>>>>>>> in my image.json file.
>>>>>>>>>>>>
>>>>>>>>>>>> Do the "meta" files look O.K. for you? I think they do, but you're
>>>>>>>>>>>> the expert
>>>>>>>>>>>> on that :D
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> T.
>>>>>>>>>>>> Peter
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> qooxdoo-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>
>
------------------------------------------------------------------------------
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
