OK, have nice vacations Martin! On Thu, Sep 30, 2010 at 8:33 PM, Martin Wittemann <[email protected]> wrote: > Hey, > I'm currently on vacation but will be back on Monday and take a deeper look > at this. > Best Martin > > Von meinem iPad gesendet > > Am 30.09.2010 um 20:31 schrieb "Jean-Noël Rivasseau" <[email protected]>: > >> Any opinions on this? >> >> On Wed, Sep 29, 2010 at 7:55 PM, Jean-Noël Rivasseau <[email protected]> >> wrote: >>> Hello >>> >>> It seems to me there is a bug in __convertObject() if the underlying >>> object already has a native toJSON implementation. Because in that >>> case you do: >>> >>> return this.__convert(incoming.toJSON(key), key); (l. 413 in Qx 1.2) >>> >>> whereas incoming.toJSON(key) already returns a String. So since it >>> will go into __convert again the return String will get extra quotes >>> and will be converted - clearly not what we want. >>> >>> I tried today not with a native implementation but with Prototype's >>> implementation and ran into a bug because of this. >>> >>> I think it is sufficient to change the line to: >>> >>> return incoming.toJSON(key); >>> >>> It works in my case anyway. Should I open a bug or someone will >>> analyze it and fix it right away? >>> >>> PS: I am still waiting for a wiki account to put our application in >>> the real life examples. If someone can make me an account that would >>> be great. >>> >>> -- >>> Jean-Noël Rivasseau >>> Directeur >>> (1) 778 786 3460 / (33) 01 82 88 05 26 >>> Kameleoon - morphing the web >>> http://www.kameleoon.com/ >>> >> >> >> >> -- >> Jean-Noël Rivasseau >> Directeur >> (1) 778 786 3460 / (33) 01 82 88 05 26 >> Kameleoon - morphing the web >> http://www.kameleoon.com/ >> >> ------------------------------------------------------------------------------ >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> _______________________________________________ >> qooxdoo-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > qooxdoo-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel >
-- Jean-Noël Rivasseau Directeur (1) 778 786 3460 / (33) 01 82 88 05 26 Kameleoon - morphing the web http://www.kameleoon.com/ ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
