Robert Godfrey wrote:
Hi Kevin,
I've already attached a patch to the JIRA for the Java broker changes.
Once we
> can agree on one or the other I'll be able to finish the Java client
work.
I think a (simple!) XML configuration file will do the trick and fully
support that.
Given that we cannot control the context in which the client library is
deployed, I think we need to be flexible in the way in which these
configuration options can be set. That is I think that it should be
possible to configure the library by passing in a
commons.Configurationobject. In that sense for the (Java) client I
think the decision over XML
vs YAML vs Properties file etc may be something of a red-herring.
However I
am +1 for using XML as the default and as the basis for a common
configuration style between clients / brokers of all languages.
This is an interesting idea. We could do that for both the broker and the
client, assuming that there's a commons-configuration class which supports the
user's desired format.
A couple of quick questions...
With the Java Client changes, will the client now always require a
configuration file? [ I hope not :-) ]
The client would only require a config file if you wanted to configure options
which would require a config file :-) Right now, this would mean SSL, but it
could mean other options down the road. It should still be possible to get the
client running without a config file.
... And at what level are you
planning to make these options configurable (application instance or
connection being the two most obvious).
I haven't dug into the client code yet so I can't really say at what level is
the most practical. Now that we've got the XML/YAML thing put to bed, I'll be
looking at this shortly. I'd like to add it at the most flexible point possible
(connection), but that will depend on what the code looks like.
--Kevin
Cheers,
Rob