On 21/05/07, Rupert Smith <[EMAIL PROTECTED]> wrote:
Could we do it the other way around, so you specify run-pyton-tests to run
them, and not if you don't? Its just that doing it this way breaks the maven
model, of it downloading and installing everything so that in theory at
least, all you have to do is type 'mvn' against a checkout and it will
build.
Rupert
I would be in favour of that but I think having them disabled by
default is very similar to what we had before. People won't run them
and we need them to be run to maintain a level of interop. There is
options to skip the tests which I would hope would be enough. We
should never be constrained my our build system. If it is causing us
problems with what we want to do then the choice of build tool perhaps
needs re-evaluated.
--
Martin
On 18/05/07, Martin Ritchie <[EMAIL PROTECTED]> wrote:
>
> [Sorry about previous half email.. forgot I was in Gmail and did
> tab-space... which sent the email.]
> So,
> I've managed to bend our maven build system to allow the python tests
> to be run against the broker.
>
> Current limitations:
>
> - You need python installed on your path :)
> - If you want to run via cygwin you need to say
> + $ mvn -Dcommand="bash -c 'python run-tests -v -I java_failing.txt'"
> - if you don't want to run the tests
> + add -Dskip-python-test to you mvn line. The test will also be
> skipped with -Pfastinstall
> - You also need to have ports 5672 free as a fresh broker is started
> for running the tests.
>
> The python tests also do not clean up their connections so you will
> see the java broker erroring on forcibly closing connections.
>
> Will JIRA that when I get the chance.
> --
> Martin Ritchie
>
