On 17/07/07, Martin Ritchie <[EMAIL PROTECTED]> wrote:
On 17/07/07, Gordon Sim <[EMAIL PROTECTED]> wrote:
> Martin Ritchie wrote:
> > On 17/07/07, Rajith Attapattu <[EMAIL PROTECTED]> wrote:
> >> One of the action items pending is to change the licensing header in
> >> source
> >> files to ASL 2.0 version.
> >> This has to be done across all languages.
> >
> > This has already been done on the Java code base.
>
> I think the issue is that there are some files with an 'old' version of
> the 2.0 license. E.g. from java:
>
>
broker/src/main/java/org/apache/qpid/server/queue/QueueNotificationListener.java
>
> (cf broker/src/main/java/org/apache/qpid/server/queue/AMQQueue.java)
>
> c++ has plenty of the old version as well...
I see that now.. I thought they had been updated.. and I would have
thought the RAT would have spotted that too. Will check the settings.
--
Martin Ritchie
Rather than spending more time on the RAT thing I just compared the
head of the java files with the license file, using:
for j in `find . -name "*.cpp"` ; do head -22 $j | grep "*" | diff -w
../java/etc/license_header.txt - > /dev/null ; if [[ $? == 1 ]] ; then
head -22 $j |grep "*" |grep contributor > /dev/null; if [[ $? == 1 ]]
; then echo $j ; fi ; fi ; done
I believe that got all the offending files, for interested I ran it
against the rest of the code base. There were a few cpp/c# files that
needed updated but only one ruby.
The spec files have their AMPQ copyright notice however the cluster
xml files have ASL on them is that correct?
Thought you cpp/c# fokes might find the list helpful when checking the
code for M2 release
CPP
./lib/broker/Daemon.cpp
./lib/common/CommonOptions.cpp
./lib/common/ExceptionHolder.cpp
./lib/common/sys/posix/EventChannel.cpp
./lib/common/sys/posix/EventChannelConnection.cpp
./lib/common/sys/posix/EventChannelThreads.cpp
./lib/common/sys/Runnable.cpp
./lib/broker/Daemon.h
./lib/common/doxygen_mainpage.h
./lib/common/ExceptionHolder.h
./lib/common/sys/AtomicCount.h
./lib/common/sys/Mutex.h
./lib/common/sys/posix/EventChannel.h
./lib/common/sys/posix/EventChannelConnection.h
./lib/common/sys/posix/EventChannelThreads.h
./tests/MockSessionHandler.h
C#
./Qpid.Buffer.Tests/Properties/AssemblyInfo.cs
./Qpid.Client/Client/Message/QpidHeaders.cs
./Qpid.Client.Tests/interop/InteropClientTestCase.cs
./Qpid.Client.Tests/interop/TestCases/TestCase1DummyRun.cs
./Qpid.Client.Tests/interop/TestCases/TestCase2BasicP2P.cs
./Qpid.Client.Tests/interop/TestCases/TestCase3BasicPubSub.cs
./Qpid.Client.Tests/interop/TestClient.cs
./Qpid.Client.Tests/interop/TopicPublisher.cs
./Qpid.Common.Tests/Properties/AssemblyInfo.cs
./Qpid.Sasl/Properties/AssemblyInfo.cs
./Qpid.Sasl.Tests/Properties/AssemblyInfo.cs
./TopicListener/Program.cs
./TopicListener/Properties/AssemblyInfo.cs
./TopicPublisher/Program.cs
./TopicPublisher/Properties/AssemblyInfo.cs
--
Martin Ritchie
