On 27/09/2007, Arnaud Simon <[EMAIL PROTECTED]> wrote: > On Thu, 2007-09-27 at 11:02 +0100, Rupert Smith wrote: > > And, yes, if a test is in 'client' but is suitable to be run against > > any broker, then it could correctly be part of integration tests. The > > reason these tests are not in that module, is because that module was > > intended for interop, against a remote broker. Therefore, the tests in > > that module are not run automatically as part of the build, because > > the extra step of automating the start/stop of remote brokers has not > > been done. > > ok, I agree with that and I am adding the step of starting/stopping a > remote broker. I am doing it in the client module for now. I would > suggest that we then review those tests and decide together the ones we > want to move into integration Tests.
Before you rush in to doing this might be work taking a look at the way the python tests are run against the java broker as part of the build just now. There is the RunBrokerWithCommand class that starts a broker runs an external command then quits It would be very easy to duplicate the pom configuration and simply provide the command 'mvn test broker=localhost:<port>'. All we need is the tests to understand the broker property. Though IIRC this won't exactly work as the current code base will not have been installed until the test cycle has completed. > Just to be sure that I correctly understand, the tests in the systests > module should not be pure JMS. If this is the case then I fully agree > with you regarding the distinction between integration tests and sys > tests. Moreover, they may be tests in the client module that we want to > move in systests. Am I right? > -- Martin Ritchie
