On 28/04/2008, Senaka Fernando <[EMAIL PROTECTED]> wrote:
> I think that these should better be in some directories under qpid, instead
>  of qpid/java. As they are not 100% Java isn't it?
>
>  Regards,
>  Senaka

+1 , Looking back a trunk again (having not paid much attention for
the last year) there does seem to be a large number of files that IMHO
should have a different home:

010ExcludeList
010ExcludeList-store
08ExcludeList
clean-dir
cpp.async.testprofile
cpp.sync.testprofile
cpp.testprofile
default.testprofile
log4j-test.xml
test-provider.properties

If it is test related it should be in a test directory. If it is a
profile to test the C++ broker then it should be with the C++ broker.

Also is the list in 010ExcludeList-store a list of tests to exclude
when running against the C++ Persistent store module that is not part
of Qpid?

as for clean-dir:
#!/bin/bash

rm -rf $@; mkdir $@

Do we really need that checked in to svn?

Can I ask that the creators of the file add a comment to the top so we
know why it is there?  It would be good to tidy up some of the old
files.

java/broker/etc/* is another example of files that needs a look at.


Regards
Martin


>  On Mon, Apr 28, 2008 at 9:37 PM, Rafael Schloming <[EMAIL PROTECTED]>
>  wrote:
>
>
>  > Senaka Fernando wrote:
>  >
>  > > Hi all,
>  > >
>  > > Is it required to have C++ test profiles in the Java directory?
>  > >
>  >
>  > Where else would they go? It would be odd to put configuration for the
>  > Java client in the C++ directory.
>  >
>  > --Rafael
>  >
>  >
>


-- 
Martin Ritchie

Reply via email to