Martin Ritchie wrote:
On 28/04/2008, Senaka Fernando <[EMAIL PROTECTED]> wrote:
I think that these should better be in some directories under qpid, instead
of qpid/java. As they are not 100% Java isn't it?
Regards,
Senaka
+1 , Looking back a trunk again (having not paid much attention for
the last year) there does seem to be a large number of files that IMHO
should have a different home:
010ExcludeList
010ExcludeList-store
08ExcludeList
clean-dir
cpp.async.testprofile
cpp.sync.testprofile
cpp.testprofile
default.testprofile
log4j-test.xml
test-provider.properties
If it is test related it should be in a test directory.
They are related to running all the tests, so no one test directory
would be an appropriate place. We could create a top level (under
qpid/java) test config directory to put them in.
If it is a
profile to test the C++ broker then it should be with the C++ broker.
They are profiles to test the Java client by running it against
something other than the in-VM broker. The ones named cpp* happen to be
set up to make it convenient to test the Java client against the cpp
broker. Putting these in the C++ directory would be very strange as they
are essentially just various configs for the ant build system to run the
test harness against specific external brokers.
Also is the list in 010ExcludeList-store a list of tests to exclude
when running against the C++ Persistent store module that is not part
of Qpid?
Yes
as for clean-dir:
#!/bin/bash
rm -rf $@; mkdir $@
Do we really need that checked in to svn?
Yes, in so far as the config for running the java tests against the cpp
broker uses it to clean up after test failures.
--Rafael
