At 12:07 PM -1000 6/11/01, Clifton Royston wrote:

>  I think then that the bug might be the assumption that flock() or
>  fcntl() by themselves will affect the file change time - which is what
>  our scripts look at - or that something else in the process of things
>  will touch the file.  I've been trying to read pop_dropcopy.c and
>  pop_updt.c, and it looks like success on some logic paths will result
>  in the p->hold file pointer (which is where the .user.pop file ends up
>  in server mode) never being written into, just fclosed at the end of
>  the session.

It sounds like the bug is that the file isn't touch()ed when 
keep-temp-drop is set, which is the only case where it matters.  This 
is very different from the file not being created or locked.  It's 
still a bug, just much less serious.

>
>  I'm not quite sure of the best place to fix it, though.

The code in that area can be tricky.  Probably the thing to do is 
touch() the file just after flock(), but that's off the top of my 
head, without looking at the code.  I think we have our own touch() 
routine, but I'd have to check.


Reply via email to