On 5 Sep 2004, at 13:52, John Peacock wrote:
Matt Sergeant wrote:I think that may be my fault, by moving the global hooks hash into the qpsmtpd object. But I think we definitely want to keep that change, so we'll fix it if its broken instead of backing it out.
Yeah, those are the changes I backed out and it started working again. You are right, though, that the global hash belongs in the object instead, so we'll need to fix it.
I honestly thought I'd tested it and it worked, so I'll look at it a bit more today.
A Makefile.PL would be nice (and easy to add - I might do one if you don't get around to it). At the moment I'm testing with Test::Verbose's "tv" command, which has a --pure-perl flag for tests without a Makefile.PL.
I'm was thinking anything which would let me do "make test" and have it do whatever was in the t/ directory. One thing that both 'tv' and 'prove' won't be able to do without assistance is to actually deliver a message (which requires the user to provide an e-mail address to receive the test message). A Makefile.PL (or probably Build.PL, since I am slowing converting everything I do to Module::Build) would allow something like this:
$> perl Build.PL
*** Please enter a mailbox to receive test messages: [EMAIL PROTECTED]
...Creating Makefile....
$> make test
...all tests run, including actual delivery...
Does this sound good?
I honestly think we can test without a test email address - we can just do unit tests and skip the queue plugins. That means queue plugins won't get tested very well, but I can live with that. My big problem is I do most of my testing completely away from any email system (on my laptop), so a test email address will never work for me. Hopefully others will have opinions too.
Matt.
