Hanno Hecker wrote:
this is the enhanced version of what I showed Matt on IRC yesterday. It
adds the RFC 1893 status codes to the messages which are returned to the
sending client.
After some prodding (Hi Ask!), I'm going back and seeing what patches
have been submitted and not applied. This a big one which looks like it
should be applied, but I have a couple of information-hiding questions.
Hanno has done a great job of abstracting out all of the error messages
and supporting Enhanced Status Codes, but a couple of times the proposed
replacement in existing plugins eliminates information we are currently
providing. For example, this chunk:
--- qpsmtpd-0.31-dev/plugins/check_badrcptto 2005-11-01
13:34:52.000000000 +0100
+++ qpsmtpd-dev/plugins/check_badrcptto 2005-11-01 14:49:02.000000000 +0100
@@ -9,9 +9,9 @@
for my $bad (@badrcptto) {
$bad = lc $bad;
$bad =~ s/^\s*(\S+)/$1/;
- return (DENY, "mail to $bad not accepted here")
+ return ($self->qp->dsn->no_such_user(DENY))
if $bad eq $from;
- return (DENY, "mail to $bad not accepted here")
+ return ($self->qp->dsn->no_such_user(DENY))
if substr($bad,0,1) eq '@' && $bad eq "[EMAIL PROTECTED]";
}
return (DECLINED);
Where we are currently quoting back which address is being denied, the
proposed replacement doesn't include $bad. Hanno's design is robust
enough that we can fix that if we want:
return ($self->qp->dsn->no_such_user(DENY, "No such user: $bad"))
My question is should we do that?
John
