> Suggestion is not to accept addresses without <> in mail() and rcpt().
We shouldn't do that unless some other major mailer is doing it. Otherwise it will bite us. > + my ($rcpt) = ($rcpt_parameter =~ m/^to:\s*(<[^>]*>)/i)[0]; > + # support addresses without <> ... maybe we shouldn't? > + ($rcpt) = "<" . ($rcpt_parameter =~ m/^to:\s*(\S+)/i)[0] . ">" > + unless $rcpt; It's perfectly valid perl, but it's hard to read. > + $rcpt = (Qpsmtpd::Address->parse($rcpt))[0]; > + ### does this one ever happen? > return $self->respond(501, "could not parse recipient") unless $rcpt; > > + return $self->respond(501, "cound not parse recipient") > + if $rcpt->format eq '<>'; > + candidate for an || -R
