On Mar 16, 2006, at 10:38 PM, Hanno Hecker (via RT) wrote:

I'd like to see a patch that makes a better API for reading the command and the command parameters. The default can still be having it space separated and provided in @_, but the hacks in mail() and rcpt() to read the rest aren't very nice so we should have an API to make it neater.

Maybe just have a method to give the full unmodified command and use that, I don't know.

Also: Tests, please! It's pretty simple to add tests for "is the parsing working right".


To add to the bikeshedding, I don't think it should be configurable -- it'd be fun to require them and see how it goes. If it doesn't work well, then just make them optional again and a rcpt_pre plugin can make them required for those who want that. Options in the core are bad, generally speaking.


 - ask

--
http://askask.com/  - http://develooper.com/


Reply via email to